Instead of this, you can also do:

bool isMaxPool = false;
if constexpr(....) {
    // const dilation check
    isMaxPool = true;
}

// Singleton check for dilation based on the maxpool flag.
// Singleton check for rest of the values.

I think the singleton check for dilation cannot be decoupled from the singleton check for the other values for MaxPool op. For MaxPool as long as one of the params of kernel/stride/padding/dilation is singleton we can canonicalize it. For AvgPool similarly we have to check for either of kernel/stride/padding to be non-singleton.

So the code will look like:

bool isMaxPool = false;
if constexpr(....) { 
    // const dilation check 
    isMaxPool = true; 
}

if (isMaxPool) {
    // check for one of kernel/stride/padding/dilation to be singleton
} else {
   // one of kernel/stride/padding to be singleton
}

if (isMaxPool) {
    expandDilation
} 

// expand other params

Is that your suggestion?

Hi @vivekkhandelwal1 can you please clarify if I understood your suggestion as captured in my previous comment? If yes, is it to make the code easier to read?

Hi @vivekkhandelwal1 any further thoughts on this?